Remove test plot line blarg #13573
Closed
Remove test plot line blarg #13573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "blarg" argument is propagated to matplotlib and there it raises an AttributeError (and not a TypeError). However, since the test doesn't seem to have a rationale, it is removed here.
Current coverage is 84.34%@@ master #13573 diff @@
==========================================
Files 138 138
Lines 51126 51126
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 43122 43122
Misses 8004 8004
Partials 0 0
|
| @@ -528,3 +528,5 @@ Bug Fixes | |||
|
|
|||
| - Bug in ``Categorical.remove_unused_categories()`` changes ``.codes`` dtype to platform int (:issue:`13261`) | |||
| - Bug in ``groupby`` with ``as_index=False`` returns all NaN's when grouping on multiple columns including a categorical one (:issue:`13204`) | |||
|
|
|||
| - Bug in ``test_graphics`` to pass the tests with matplotlib 1.9.2 | |||
There was a problem hiding this comment.
you mean 1.5.2., instead say compat with matplotlib 1.5.2
There was a problem hiding this comment.
I don't think release note is needed, because it is test change.
jreback
added
Visualization
3 tasks
|
Closing this in favour of PR #13641 |
|
@olebole Even though it is not merged, thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Superceded by #13641
git diff upstream/master | flake8 --diffThe "blarg" argument is propagated to matplotlib and there it raises an
AttributeError (and not a TypeError).
However, since the test doesn't seem to have a rationale, it is removed here.